Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify incompressible solver based on burgers solver #169

Merged
merged 41 commits into from
Aug 8, 2023
Merged

simplify incompressible solver based on burgers solver #169

merged 41 commits into from
Aug 8, 2023

Conversation

zhichen3
Copy link
Collaborator

based on the previous burgers pr.

  1. Simplifies the get_interface_states function in incomp_interface.py from burgers/burgers_interface.py
  2. Also, let incompressible inherit from burgers to eliminate the method_compute_timestep function.

@zhichen3 zhichen3 marked this pull request as draft April 21, 2023 19:11
@zhichen3 zhichen3 changed the title Incompressible solver simplify based on burgers solver simplify incompressible solver based on burgers solver Apr 21, 2023
@zhichen3 zhichen3 marked this pull request as ready for review August 4, 2023 02:46
@zhichen3 zhichen3 mentioned this pull request Aug 4, 2023
Merged
@zingale zingale merged commit 70445dc into python-hydro:main Aug 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhichen3 @zingale